-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow color numbers instead of descriptive names #68
Conversation
|
this was suggested by tgm4883 on slack. |
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 36 36
Lines 808 809 +1
=====================================
+ Hits 808 809 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will fail as the canonicalize feature has not been enabled on the type. Not overly sure why there is a canonicalize method in the first place. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕
"Sometimes, all you need is a hammer."
ba836cf
to
b54bfcb
Compare
"Sometimes, all you need is a hammer."