Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow color numbers instead of descriptive names #68

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Oct 20, 2018

"Sometimes, all you need is a hammer."

@DavidS
Copy link
Contributor Author

DavidS commented Oct 20, 2018

this was suggested by tgm4883 on slack.

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          36     36           
  Lines         808    809    +1     
=====================================
+ Hits          808    809    +1
Impacted Files Coverage Δ
lib/puppet/type/panos_tag.rb 100% <ø> (ø) ⬆️
lib/puppet/provider/panos_tag/panos_tag.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408163a...b54bfcb. Read the comment docs.

Copy link
Contributor

@Thomas-Franklin Thomas-Franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will fail as the canonicalize feature has not been enabled on the type. Not overly sure why there is a canonicalize method in the first place. 🤷‍♂️

Copy link
Contributor

@Thomas-Franklin Thomas-Franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕

Copy link
Contributor

@Thomas-Franklin Thomas-Franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕

Copy link
Contributor

@Thomas-Franklin Thomas-Franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, even thought there is a canonicalize method, the feature has not been enabled which means this currently fails when applying a manifest with codes as colours. 😕

"Sometimes, all you need is a hammer."
@DavidS DavidS added the feature New feature or request label Oct 22, 2018
@Thomas-Franklin Thomas-Franklin merged commit 4c5133c into puppetlabs:master Oct 23, 2018
@DavidS DavidS deleted the allow-color-tags branch October 23, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants