(FM-7625) implement finegrained configuration support for SSL verification #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be adding unit tests tomorrow. So this is more for early review at this point. |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 99.02% 99.15% +0.13%
==========================================
Files 39 39
Lines 919 948 +29
==========================================
+ Hits 910 940 +30
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
DavidS
suggested changes
Feb 19, 2019
Thomas-Franklin
force-pushed
the
fm-7625
branch
from
c7e22b8
to
f36cf9a
Compare
|
Tagging @clairecadman for the readme changes. @DavidS the changes proposed have been made I believe :-) |
DavidS
suggested changes
Feb 19, 2019
| ciphers: @ciphers ? @ciphers.join(':') : @ciphers, | ||
| verify_callback: ->(preverify_ok, cert_store) do | ||
| verify_callback(preverify_ok, cert_store) | ||
| end) |
There was a problem hiding this comment.
You might be able to directly convert the verify_callback method into a proc by using the syntax described in https://stackoverflow.com/a/4294660/4918
There was a problem hiding this comment.
I did want to split it out to make it easier to test the method
clairecadman
approved these changes
Feb 19, 2019
Thomas-Franklin
force-pushed
the
fm-7625
branch
from
f36cf9a
to
36fbb23
Compare
willmeek
force-pushed
the
fm-7625
branch
2 times, most recently
from
ccb6290
to
dc72b66
Compare
added 2 commits
March 14, 2019 16:26
This will make use of `verify_mode` control in order to do verification. Can also specify which `ssl_ca_file` to use for verification other wise it will use the certs in `OpenSSL::X509::DEFAULT_CERT_FILE`, e.g.: `ruby -ropenssl -e 'puts OpenSSL::X509::DEFAULT_CERT_FILE'` The SHA256 fingerprint can be specified for additional verification.
Thomas-Franklin
force-pushed
the
fm-7625
branch
from
dc72b66
to
2be8cdf
Compare
Always return the exception's stack trace in the correct place in the bolt _error message.
DavidS
changed the title
DavidS
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make use of
verify_modecontrol in order to dopeer,client-once, orfail-no-peerverification.Can also specify which
ca_fileto use for verification other wise it will use the certs inOpenSSL::X509::DEFAULT_CERT_FILE, e.g.:ruby -ropenssl -e 'puts OpenSSL::X509::DEFAULT_CERT_FILE'The SHA256 fingerprint can be specified for additional verification.