(FM-7971) backwards compatibility with PE 2019.0 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
+ Coverage 99.15% 99.26% +0.1%
=========================================
Files 39 40 +1
Lines 948 1084 +136
=========================================
+ Hits 940 1076 +136
Misses 8 8
Continue to review full report at Codecov.
|
Thomas-Franklin
force-pushed
the
fm-7971
branch
3 times, most recently
from
c80e0ee
to
60594c2
Compare
Thomas-Franklin
force-pushed
the
fm-7971
branch
from
60594c2
to
bfd6e1b
Compare
da-ar
approved these changes
Apr 23, 2019
Thomas-Franklin
changed the title
Thomas-Franklin
changed the title
|
This is blocked for timebeing on a release of 1.6.4 RSAPI to rubygems |
Thomas-Franklin
force-pushed
the
fm-7971
branch
4 times, most recently
from
11408ec
to
911314b
Compare
added 4 commits
April 23, 2019 16:50
This code is a horrible workaround for the transport work that this module was converted to support but meant that current STS puppet versions would not work. This code can be reverted in August 2019 once 2019.0 STS ends.
This is to satisfy the condition that the version of bolt on a 6.0.x PE instalation may use the 1.6.x RSAPI version.
Example of a success with 1.6.x RSAPI and bolt:
```
Started on cgnodswd2r9rm9e.delivery.puppetlabs.net...
Finished on cgnodswd2r9rm9e.delivery.puppetlabs.net:
{
"apikey": "xxx"
}
Successful on 1 node: cgnodswd2r9rm9e.delivery.puppetlabs.net
Ran on 1 node in 2.85 seconds
```
Thomas-Franklin
force-pushed
the
fm-7971
branch
from
911314b
to
7d38a29
Compare
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support to the module to work with RSAPI 1.6.x that Puppet 6.0.x is shipped with. This PR could be reverted once STS of PE 2019.0 is over.