(maint) updating the ssl_fingerprint to accept spaced and colon SHA25… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6 notation Previously the fingerprint expected it to be the format `XX:XX:...` althought some browsers would display the fingerprint in `XX XX XX ...` notation which would cause issues if copied directly from the browser. This change will allow it to be provided in the following formats `XX XX XX ...`, `xxxxxx...` or `XX:XX:XX...` which should cover all possible formats when retrieving the SHA256 fingerprint from a certificate on the firewall.
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 948 948
=======================================
Hits 940 940
Misses 8 8
Continue to review full report at Codecov.
|
DavidS
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…6 notation
Previously the fingerprint expected it to be the format
XX:XX:...althought some browsers would display the fingerprint inXX XX XX ...notation which would cause issues if copied directly from the browser.This change will allow it to be provided in the following formats
XX XX XX ...,xxxxxx...orXX:XX:XX...which should cover all possible formats when retrieving the SHA256 fingerprint from a certificate on the firewall.