(FM-8104) Add implicit default values #92
Conversation
| @@ -71,15 +71,15 @@ | |||
| xpath: 'interface/text()', | |||
| }, | |||
| metric: { | |||
| type: 'Optional[String]', | |||
| desc: 'Specify a valid metric for the static route (1 - 65535).', | |||
| type: 'Integer[1, 65535]', | |||
There was a problem hiding this comment.
these type changes are breaking interface changes. Please change this to accept Variant[String, Integer[..]] and add a canonicalize method to the provider that transforms the value to the preferred form.
There was a problem hiding this comment.
If someone from the eng team can pick this up and round it out that would be super. I'm running full speed on my demo work.
This PR adds implicit default values to resource output for panos_nat_policy panos_security_policy_rule panos_static_route_base This is not exhaustive and additonal providers may need to be updated. This PR also corrects some data types in panos_static_route
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 99.27% 99.28% +<.01%
==========================================
Files 40 40
Lines 1102 1114 +12
==========================================
+ Hits 1094 1106 +12
Misses 8 8
Continue to review full report at Codecov.
|
|
@da-ar changes look good. I suppose at some point we'll want to add deprecation warnings and push users to using stricter types to get the benefits of validation. Thank you for closing this out! |
This PR adds implicit default values to resource output for panos_nat_policy panos_security_policy_rule panos_static_route_base
This is not exhaustive and additonal providers may need to be updated.
This PR also corrects some data types in panos_static_route