Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8110) fix panos_nat_policy source address translation #93

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

shermdog
Copy link
Contributor

This commit changes the attribute names to lowercase as puppet does not support attributes that start with an uppercase
Also set provider to optionally send SAT IP address as it is not required

This commit changes the attribute names to lowercase as puppet does not support attributes that start with an uppercase
Also set provider to optionally send SAT IP address as it is not required
@shermdog shermdog requested review from DavidS and da-ar May 28, 2019 18:10
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #93 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #93      +/-   ##
========================================
+ Coverage   99.26%   100%   +0.73%     
========================================
  Files          40     40              
  Lines        1084   1084              
========================================
+ Hits         1076   1084       +8     
+ Misses          8      0       -8
Impacted Files Coverage Δ
lib/puppet/type/panos_nat_policy.rb 100% <ø> (ø) ⬆️
...ppet/provider/panos_nat_policy/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_tag/panos_tag.rb 100% <0%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75e4f5...f8c803f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #93 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #93      +/-   ##
========================================
+ Coverage   99.26%   100%   +0.73%     
========================================
  Files          40     40              
  Lines        1084   1084              
========================================
+ Hits         1076   1084       +8     
+ Misses          8      0       -8
Impacted Files Coverage Δ
lib/puppet/type/panos_nat_policy.rb 100% <ø> (ø) ⬆️
...ppet/provider/panos_nat_policy/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_tag/panos_tag.rb 100% <0%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75e4f5...f8c803f. Read the comment docs.

@da-ar da-ar merged commit 743daf6 into puppetlabs:master Jun 3, 2019
@da-ar da-ar added the bugfix Signify a bug fix label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Signify a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants