Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8111) increase system facts #94

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Conversation

shermdog
Copy link
Contributor

This commit increases the system fact coverage by moving to a show command vs api.version

@shermdog shermdog requested review from DavidS and da-ar May 28, 2019 23:10
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #94 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #94      +/-   ##
========================================
+ Coverage   99.26%   100%   +0.73%     
========================================
  Files          40     40              
  Lines        1084   1102      +18     
========================================
+ Hits         1076   1102      +26     
+ Misses          8      0       -8
Impacted Files Coverage Δ
lib/puppet/transport/panos.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_tag/panos_tag.rb 100% <0%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75e4f5...34346dc. Read the comment docs.

This commit increases the system fact coverage by moving to a show command vs api.version
@da-ar da-ar merged commit 482e5f7 into puppetlabs:master Jun 3, 2019
@da-ar da-ar added the feature New feature or request label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants