Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8107) Add insert_after attribute for policy rule ordering #96

Merged
merged 2 commits into from
Jun 5, 2019
Merged

(FM-8107) Add insert_after attribute for policy rule ordering #96

merged 2 commits into from
Jun 5, 2019

Conversation

da-ar
Copy link

@da-ar da-ar commented May 31, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #96 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #96      +/-   ##
========================================
- Coverage   99.26%    99%   -0.27%     
========================================
  Files          40     40              
  Lines        1084   1101      +17     
========================================
+ Hits         1076   1090      +14     
- Misses          8     11       +3
Impacted Files Coverage Δ
lib/puppet/transport/panos.rb 100% <100%> (ø) ⬆️
...ppet/provider/panos_nat_policy/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/type/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_provider.rb 100% <100%> (ø) ⬆️
...security_policy_rule/panos_security_policy_rule.rb 100% <100%> (ø) ⬆️
lib/puppet/type/panos_security_policy_rule.rb 100% <100%> (ø) ⬆️
lib/puppet/util/network_device/panos/device.rb 88.88% <0%> (-11.12%) ⬇️
lib/puppet_x/puppetlabs/panos/transport_shim.rb 98.48% <0%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75e4f5...aeeae46. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #96 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage     100%   99.91%   -0.09%     
==========================================
  Files          40       40              
  Lines        1119     1136      +17     
==========================================
+ Hits         1119     1135      +16     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/puppet/type/panos_ipv6_static_route.rb 100% <ø> (ø) ⬆️
lib/puppet/transport/panos.rb 100% <100%> (ø) ⬆️
...ppet/provider/panos_nat_policy/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/type/panos_nat_policy.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_provider.rb 100% <100%> (ø) ⬆️
...security_policy_rule/panos_security_policy_rule.rb 100% <100%> (ø) ⬆️
lib/puppet/type/panos_security_policy_rule.rb 100% <100%> (ø) ⬆️
.../provider/panos_path_monitor/panos_path_monitor.rb 75% <0%> (-25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b925797...ea61acf. Read the comment docs.

@da-ar
Copy link
Author

da-ar commented Jun 3, 2019

@shermdog updated with autorequire to ensure that the rules exist

@da-ar da-ar merged commit d650b94 into puppetlabs:master Jun 5, 2019
@da-ar da-ar deleted the policy_order branch June 5, 2019 10:57
@da-ar da-ar added the feature New feature or request label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants