Configure dependencies and notifications #14

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

phemmer commented Sep 18, 2012

This fixes 2 issues.

  1. It prevents enabling the module if the compilation failed. Otherwise if compilation fails, apache will generate an error when it tries to start and the binary doesn't exist.
  2. Sets up notifications so that if the config is updated, apache reloads.

Patrick Hemmer added some commits Sep 18, 2012

Patrick Hemmer
Add support for nginx
Package was split into passenger::apache and passenger::nginx
The 'passenger' class just installs passenger and no modules
Member

ryanycoleman commented Oct 19, 2012

Hi @phemmer, I'm sorry it's taken us so long to get back to you. Would you mind rebasing your branch for our merge?

Contributor

phemmer commented Oct 19, 2012

Sure, I've created a new pull request for it though. I forgot about this and introduced more changes into my own branch (to support nginx). #16

I can create another feature branch if you want the other changes I made. They add support for nginx.

@phemmer phemmer closed this Oct 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment