Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIE-1030 Honor User specified base paths #107

Merged

Conversation

gsparks
Copy link
Contributor

@gsparks gsparks commented Mar 3, 2022

When a user specifies a base path for their logfile_basepath and
lockdir_bathpath in the module parameters we currently clip the base
path to two directories deep. This is often an invalid assumption. This
change uses the exact basepath that the user supplies for each
parameter respectively.

@gsparks gsparks requested a review from a team as a code owner March 3, 2022 20:06
@puppet-community-rangefinder
Copy link

pe_event_forwarding::base_path is a function

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

When a user specifies a base path for their logfile_basepath and
lockdir_bathpath in the module parameters we currently clip the base
path to two directories deep. This is often an invalid assumption. This
change uses the exact basepath that the user supplies for each
parameter respectively.
@gsparks gsparks force-pushed the PIE-1030_honor_user_specified_base_paths branch from e965e09 to 7a8367f Compare March 7, 2022 17:13
@nam054 nam054 merged commit 8629774 into puppetlabs:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants