Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1162) Update cron user #115

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Jan 3, 2023

Summary

Changes to init.pp to default cron owner to the $owner variable.

Detailed Description

  • Updated L118 in manifests/init.pp from root -> $owner.
  • Updated L49 and L49 spec/acceptance/class_spec.rb to include the pe-puppet user in the crontab command.

@coreymbe coreymbe requested a review from a team as a code owner January 3, 2023 21:54
@puppet-community-rangefinder
Copy link

pe_event_forwarding is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job finding the spec error LGTM

@actowery actowery merged commit d77df7f into puppetlabs:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants