Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Fix base_path function #118

Merged
merged 1 commit into from
May 23, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Apr 25, 2023

Summary

This maintenance PR addresses a bug in the internal base_path function where a path in the cron command is created with a double slash (//) when a user provided path ends in a slash.

Detailed Description

  • Updated CHANGELOG.md
  • Fix lint error in init.pp by utilizing Heredoc
  • lib/puppet/functions/pe_event_forwarding/base_path.rb
    • Remove any trailing / from user provided base path.

@coreymbe coreymbe requested a review from a team as a code owner April 25, 2023 17:46
@CLAassistant
Copy link

CLAassistant commented Apr 25, 2023

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

pe_event_forwarding::base_path is a function

Breaking changes to this file WILL impact these 1 modules (exact match):

pe_event_forwarding is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@coreymbe coreymbe force-pushed the MAINT-base_path_fix branch 2 times, most recently from 7763b8e to c0e6068 Compare May 22, 2023 22:38
manifests/init.pp Outdated Show resolved Hide resolved
@coreymbe coreymbe force-pushed the MAINT-base_path_fix branch 2 times, most recently from 285e6c7 to 8d735a5 Compare May 23, 2023 19:43
@coreymbe coreymbe merged commit 8f6cd45 into puppetlabs:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants