(PIE-1300) Puppet 8 Compatibility

[coreymbe]

Summary

This commit contains changes made by pdk, rubocop and lint; as well as manual changes to metadata.json to add Puppet 8.

Honeycomb steps have been removed from workflows spec.yml and integration_test.yml.

Detailed Description

• PDK Update:

  • .devcontainer/devcontainer.json
  • .rubocop.yml
  • .pdkignore
  • Rakefile
  • Gemfile
  • .github/workflows/spec.yml

• Rubocop Changes:

  • plans/acceptance/provision_machines.pp
  • plans/acceptance/pe_server.pp
  • lib/puppet/functions/pe_event_forwarding/base_path.rb
  • files/util/logger.rb
  • files/collect_api_events.rb

• Lint Changes:

  • manifests/init.pp

---

Maint Changes:

• README.md

  • Add note about v2 removing support for PE 2019.8.12.

• metadata.json

  • Bumped module to v2.
  • Added Puppet 8 / Pulled Puppet 6 / Updated supported OS list.

• .github/workflows/integration_test.yml

  • Set PUPPET_GEM_VERSION to Puppet 7.
  • Update PE version to current LTS (2021.7.2).
  • Removed Honeycomb steps.

• .github/workflows/spec.yml

  • Removed Honeycomb steps.

• spec/acceptance/index_spec.rb

  • Fix locale error.

• rakelib/helpers.rake

  • Remove use of RspecJunitFormatter.

• plans/acceptance/pe_server.pp

  • Set admin pass during install.
  • Bump PE version.

---

Ruby 3 Changes:

• spec/spec_helper_local.rb

  • Add double splat (**) to pass keyword args instead of Hash object.

• files/util/index.rb

  • YAML#safe_load keyword args.

---

[actowery]

lots of changes for puppet8 thanks for doing all this