Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1328) secure sensitive data #122

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Jul 28, 2023

Summary

This PR utilizes the custom function pe_event_forwarding::secure to move credential data to a separate file.

Detailed Description

  • Added manifests/v2_cleanup.pp
  • Added files/collection_secrets.yaml.epp
  • Renamed templates/events_collection.yaml.epp -> templates/collection_settings.yaml.epp
  • Updated lib/puppet/functions/pe_event_forwarding/secure.rb
    • Function now accepts and returns a hash instead of string
  • Updated manifests/init.pp
    • Move credentials to collection_secrets.yaml
    • Remove events_collection.yaml via ::v2_cleanup subclass
  • Updated files/collect_api_events.rb
    • Utilize credentials from collection_secrets.yaml
  • Generated updates for REFERENCE.md
  • Updated CHANGELOG.md
  • Updates spec tests
    • spec/acceptance/class_spec.rb
    • spec/classes/init_spec.rb

@coreymbe coreymbe requested a review from a team as a code owner July 28, 2023 18:31
@coreymbe coreymbe force-pushed the PIE-1328-secure_sensitive_data branch 3 times, most recently from b322a63 to 2a135f6 Compare July 31, 2023 20:12
@coreymbe coreymbe force-pushed the PIE-1328-secure_sensitive_data branch from 2a135f6 to 0419264 Compare July 31, 2023 20:16
Copy link
Collaborator

@gregohardy gregohardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregohardy gregohardy merged commit 389e126 into puppetlabs:main Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants