Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PIE-1460) Collection filtering feature #124

Merged
merged 1 commit into from
Feb 26, 2024
Merged

(PIE-1460) Collection filtering feature #124

merged 1 commit into from
Feb 26, 2024

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Feb 16, 2024 •
edited
Loading

Summary

This commit adds the ability to filter which events to collect before collection occurs.

Detailed Description

Updated files/api/activity.rb

  • Removed SERVICE_NAMES_WITHOUT_RBAC as filtering is now done in collect_api_events.rb.

Updated files/collect_api_events.rb

  • Check settings file to build list of service names to collect from the Activity API.
  • Check settings file to determine if events should be collected from the Orchestrator API.

Updated manifests/init.pp

  • Added new parameters ::skip_events and ::skip_jobs.

Updated templates/collection_settings.yaml.epp

  • Add new parameters to the settings file template.

Updated spec/spec_helper_acceptance_local.rb

  • Refactored tests against disabling rbac collection to utilize the skip_events parameter.

Documented changes in:

  • README.md
  • REFERENCE.md
  • CHANGELOG.md

@coreymbe coreymbe requested a review from a team as a code owner February 16, 2024 04:56
actowery
actowery approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small syntax comment, approving for whichever decision you make

files/collect_api_events.rb Show resolved Hide resolved
@coreymbe coreymbe force-pushed the PIE-1460-collection_filtering branch from 0a35aa2 to f35777e Compare February 26, 2024 17:21
@coreymbe coreymbe force-pushed the PIE-1460-collection_filtering branch from f35777e to 9e41844 Compare February 26, 2024 19:01
actowery
actowery approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work catching that bug 🎉

@actowery actowery merged commit 8660b1c into puppetlabs:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actowery actowery actowery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreymbe @actowery