Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1462) Add timeout parameter #126

Merged
merged 1 commit into from Mar 20, 2024

Conversation

coreymbe
Copy link
Contributor

Summary

This commit adds an optional parameter pe_event_forwarding::timeout to allow users to configure the HTTP timeout used when collecting events.

Detailed Description

  • manifests/init.pp
    • Added timeout parameter.
  • templates/collection_settings.yaml.epp
    • Added timeout parameter.
  • files/api/activity.rb
    • Updated class functions to accept timeout.
  • files/api/orchestrator.rb
    • Updated class functions to accept timeout.
  • files/collect_api_events.rb
    • Added timeout variable with default of 60 seconds.
  • files/util/http.rb
    • Removed default timeout.
    • Convert timeout to an integer.
  • files/util/pe_http.rb
    • Added debug log message to indicate what value was used for the timeout.
  • Updated README.md
  • Updated REFERENCE.md
  • Updated CHANGELOG.md
  • Maintenance:
    • manifests/init.pp - Ensure sensitivate data is redacted from logs.

@coreymbe coreymbe requested a review from a team as a code owner March 19, 2024 22:28
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@actowery actowery merged commit 07add51 into puppetlabs:main Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants