(SUP-2643) Add option to override version assertion
Prior to this commit, there was no way to force an override to the PE version assertion. This commit adds a new parameter that will override the PE version check and output a warning when enabled. This is useful in testing new PE versions that are not yet supported by the module.
adds spaces around the brackets to meet bash syntax
Co-authored-by: Reid Vandewiele <reid@puppet.com>
uses proper quotes around variable
Co-authored-by: Reid Vandewiele <reid@puppet.com>
removes -p flag to avoid future mktemp conflicts
Co-authored-by: Reid Vandewiele <reid@puppet.com>
uses proper syntax for interpolation
Co-authored-by: Reid Vandewiele <reid@puppet.com>
removes the name argument from mktemp
Co-authored-by: Reid Vandewiele <reid@puppet.com>
Merge pull request #215 from puppetlabs/SOLARCH-622
Improve reliability of downloading PE tarball
Return accurate 'supported' data even when unsafe
The new $permit_unsafe_versions parameter allows the assert_supported_pe_version() function to not raise on failure, but it should always return accurate data about whether or not the given version is or isn't supported.
Merge pull request #204 from jarretlavallee/sup_2643_version_override
Add development and testing option to permit installing unsupported PE versions
Improve logging of peadm::download
Adjust message language, add message for moving temp file into target location on successful download
Determine signing key from asc file
Rather than expecting that downloaded files will be signed with a known key, simply use the key from the signature asc file. The purpose of this validation isn't to validate authenticity. It is only to validate digest.
Merge pull request #219 from puppetlabs/GH-216
Determine validation key from asc signature file
Catch mv errors when downloading
If moving the temporary file into the final location fails, make sure that error is caught and return values set appropriately.
Merge pull request #220 from puppetlabs/maint-catch-mv-errors
Catch mv errors when downloading
Fail agent_install if agent is already installed
The PE bash installer script doesn't support re-configuring an existing agent, which is critical to our use case. Therefore, we should fail if the agent is already installed, since we cannot guarantee correct configuration in that scenario.
Remove inotify and log watching service from docker examples
* Previously we could spit out logs of what bolt was doing.
This feature is now natively supported in bolt and there
is no need for installing inotify and supporting services.
* Additionally, this adds the old pe installer gpg key
* Reformats json and yaml files under spec/dockerUse the docker host's bolt command and bolt project file
* The previously implementation used pdk which ships with an
older version of bolt. This allows the user to use the local
installation of bolt which is the same procedure as using peadm
directly.
* This also fixes a few issues around module dependencies and relying
on the fixtures path. Users are no longer required to have pdk
or run bundle commands. Since this uses pure bolt the entire process
mimics that of a real installation and usage.
* Updates install and upgrade scripts to use bolt commandsMerge pull request #223 from puppetlabs/fail-agent_install-on-reinstall
Fail agent_install if agent is already installed
Adds ability to optionally add agents for docker examples
* Previously the documentation detailed instructions for
how to add agents to a docker example cluster. This
adds a script to do the dirty work.Merge pull request #224 from nwops/docker_fix
Updates docker to use bolt commands
Merge pull request #227 from puppetlabs/SOLARCH-716
Accidentally closed instead of merging Merging despite broken test @reidmv advised of issue. Will fix the test separately
Fix failing table output tests
The gem was updated and the output format changed slightly. These tests should probably just be removed; they are too exact and finicky.
Merge pull request #228 from puppetlabs/fix-table-tests
Fix failing table output tests
Merge pull request #230 from puppetlabs/release-prep
Release prep v3.3.0