-
Notifications
You must be signed in to change notification settings - Fork 613
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-postgresql
base: v10.0.0
head repository: puppetlabs/puppetlabs-postgresql
compare: v10.0.1
- 7 commits
- 5 files changed
- 3 contributors
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 608d8d7 - Browse repository at this point
Copy the full SHA 608d8d7View commit details -
Fix
postgresql::default()return value for unknown parametersWhen calling `postgresql::default()` with a name that has no corresponding parameter, the function returns the string "postgresql::globals::<parameter-name>" which is probably not intended given the comment above the code. The usage of pick seems to indicate that an exception should be raised when a parameter is not found in `params` nor `globals.pp`, so adjust the code accordingly.
Configuration menu - View commit details
-
Copy full SHA for 6cb50cb - Browse repository at this point
Copy the full SHA 6cb50cbView commit details -
Simplify
postgresql::default()`postgresql::params` inherits from `postgresql::globals` so any variable defined in `postgresql::globals` can be accessed by reading it from `postgresql::params`, making it redundant to check both. diff --git a/functions/default.pp b/functions/default.pp index e36610b..41b5006 100644 --- a/functions/default.pp +++ b/functions/default.pp @@ -8,8 +8,7 @@ function postgresql::default( ) { include postgresql::params - #search for the variable name in params first - #then fall back to globals if not found - pick(getvar("postgresql::params::${parameter_name}"), - getvar("postgresql::globals::${parameter_name}")) + # Search for the variable name in params. + # params inherits from globals, so it will also catch these variables. + pick(getvar("postgresql::params::${parameter_name}")) }Configuration menu - View commit details
-
Copy full SHA for 4e15857 - Browse repository at this point
Copy the full SHA 4e15857View commit details
Commits on Oct 12, 2023
-
Merge pull request #1529 from puppetlabs/fix-postgresql_password
Fix the `postgresql::postgresql_password()` function
Configuration menu - View commit details
-
Copy full SHA for f2f2754 - Browse repository at this point
Copy the full SHA f2f2754View commit details -
Merge pull request #1530 from puppetlabs/fix-postgresql_default
Fix `postgresql::default()` return value for unknown parameters
Configuration menu - View commit details
-
Copy full SHA for e1c3a24 - Browse repository at this point
Copy the full SHA e1c3a24View commit details -
GitHub Actions committed
Oct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 4bdd511 - Browse repository at this point
Copy the full SHA 4bdd511View commit details -
Merge pull request #1531 from puppetlabs/release-prep
Release prep v10.0.1
Configuration menu - View commit details
-
Copy full SHA for 05bc715 - Browse repository at this point
Copy the full SHA 05bc715View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v10.0.0...v10.0.1