Strip quotes from role names #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI check just needs to be rerun. It failed because of a timeout on one of the tasks. The tasks all ran successfully against my fork. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a bug in the detection of existing permissions for roles being granted USAGE on ALL SEQUENCES. We found that role names that need to be quoted (like those containing -) will come back from the $custom_unless queries wrapped in double quotes, causing the query, which is limited using the unquoted role name, never to detect the presence of permissions. When the grant is set to 'present' this causes the grant to be applied on every puppet run. When the grant is set to 'absent' this causes the permissions to remain, even though they should be removed. Stripping out the double quotes from the role name within the query resolves the issue.
We have validated this on 9.4+, but I see no reason why it wouldn't work on across the board.