(MODULES-8553) Fix dependency on apt by explicitly using 'puppetlabs-postgresql' as tag

[HelenCampbell]

Updating to explicitly call puppetlabs-postgresql as a tag for apt to avoid dependency conflicts.

[puppet-community-rangefinder]

postgresql::repo::apt_postgresql_org is a class

that may have no external impact to Forge modules.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[HelenCampbell]

Before Fix:

example
  on oraclelinux-7-x86_64
    should compile into a catalogue without dependency cycles
  on windows-2008 R2-x64
    should compile into a catalogue without dependency cycles
  on windows-10-x64
    should compile into a catalogue without dependency cycles
  on debian-8-x86_64
    should compile into a catalogue without dependency cycles (FAILED - 1)
  on ubuntu-16.04-x86_64
    should compile into a catalogue without dependency cycles (FAILED - 2)
  on windows-2012 R2-x64
    should compile into a catalogue without dependency cycles
  on scientific-7-x86_64
    should compile into a catalogue without dependency cycles
  on centos-7-x86_64
    should compile into a catalogue without dependency cycles
  on redhat-7-x86_64
    should compile into a catalogue without dependency cycles

Failures:

  1) example on debian-8-x86_64 should compile into a catalogue without dependency cycles
     Failure/Error: it { is_expected.to compile }
       dependency cycles found: (Package[apt-transport-https] => Apt::Source[apt.postgresql.org] => Package[apt-transport-https])
     # ./spec/classes/example_spec.rb:8:in `block (4 levels) in <top (required)>'

  2) example on ubuntu-16.04-x86_64 should compile into a catalogue without dependency cycles
     Failure/Error: it { is_expected.to compile }
       dependency cycles found: (Package[apt-transport-https] => Apt::Source[apt.postgresql.org] => Package[apt-transport-https])
     # ./spec/classes/example_spec.rb:8:in `block (4 levels) in <top (required)>'

Deprecation Warnings:

puppetlabs_spec_helper: defaults `mock_with` to `:mocha`. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total

Finished in 2.95 seconds (files took 3.21 seconds to load)
9 examples, 2 failures

Failed examples:

rspec './spec/classes/example_spec.rb[1:4:1]' # example on debian-8-x86_64 should compile into a catalogue without dependency cycles
rspec './spec/classes/example_spec.rb[1:5:1]' # example on ubuntu-16.04-x86_64 should compile into a catalogue without dependency cycles

After Fix:

example
  on oraclelinux-7-x86_64
    should compile into a catalogue without dependency cycles
  on windows-2008 R2-x64
    should compile into a catalogue without dependency cycles
  on windows-10-x64
    should compile into a catalogue without dependency cycles
  on debian-8-x86_64
    should compile into a catalogue without dependency cycles
  on ubuntu-16.04-x86_64
    should compile into a catalogue without dependency cycles
  on windows-2012 R2-x64
    should compile into a catalogue without dependency cycles
  on scientific-7-x86_64
    should compile into a catalogue without dependency cycles
  on centos-7-x86_64
    should compile into a catalogue without dependency cycles
  on redhat-7-x86_64
    should compile into a catalogue without dependency cycles

Deprecation Warnings:

puppetlabs_spec_helper: defaults `mock_with` to `:mocha`. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total

Finished in 2.89 seconds (files took 3.57 seconds to load)
9 examples, 0 failures