(MODULES-8553) Further cleanup for package tag issues

[HelenCampbell]

Update all this modules tagged packages to use 'puppetlabs-postgresql' instead of just 'postgresql' which is ambiguous and causing dependancy issues.

[puppet-community-rangefinder]

postgresql::client is a class

Breaking changes to this file WILL impact these modules (exact match):

• sbadia-gitlab
• katello-candlepin
• theforeman-foreman

Breaking changes to this file MAY impact these modules (near match):

• lboynton-gitlab
• vshn-uhosting
• simp-foreman
  postgresql::lib::devel is a class

---

Breaking changes to this file MAY impact these modules (near match):

• nnutter-testdb
• nicopaez-alfred
• sbadia-gitlab
• mukaibot-bamboo
• jmkeyes-netbox
  postgresql::lib::docs is a class

---

that may have no external impact to Forge modules.

postgresql::lib::java is a class

Breaking changes to this file MAY impact these modules (near match):

• razorsedge-cloudera
  postgresql::repo::apt_postgresql_org is a class

---

that may have no external impact to Forge modules.

postgresql::repo::yum_postgresql_org is a class

that may have no external impact to Forge modules.

postgresql::server::contrib is a class

Breaking changes to this file WILL impact these modules (exact match):

• mukaibot-bamboo
• SchnWalter-happydev
• puppetlabs-puppetdb
• npwalker-pe_external_postgresql

postgresql::server::extension is a type

Breaking changes to this file WILL impact these modules (exact match):

• puppetlabs-puppetdb
• npwalker-pe_external_postgresql

Breaking changes to this file MAY impact these modules (near match):

• tedivm-hieratic
  postgresql::server::install is a class

---

that may have no external impact to Forge modules.

postgresql::server::plperl is a class

that may have no external impact to Forge modules.

postgresql::server::plpython is a class

that may have no external impact to Forge modules.

postgresql::server::postgis is a class

Breaking changes to this file WILL impact these modules (exact match):

• conzar-pidservice
• camptocamp-postgis
• landcareresearch-pidservice
• conzar-ckan
• landcareresearch-postgis

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[Sharpie]

Looks good! The only thing I found was that lib/python.pp and lib/perl.pp are missing tags on their packages. The package names defined in params.pp appear to line up with what the Postgres repos provide. For example:

https://download.postgresql.org/pub/repos/yum/9.6/redhat/rhel-7.6-x86_64/

[HelenCampbell]

Thanks for the review @Sharpie , that's it up to date with those two manifests as well :) Let me know if this is ready to go and I'll get it merged and a release of the back of it.

[Sharpie]

Looks good to me!