Fix: When assigning a tablespace to a database, no equal sign is needed in the query #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Does anyone want to merge this, or has comments on this patch? Bert |
|
Thanks for submitting the PR @biertie . |
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Fix: When assigning a tablespace to a database, no equal sign is needed in the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation* no equal sign is needed when creating or altering a database. It is working during the database creation; but it fails during an alter statement. Therefore I propose to remove the equal sign both during the creation of the database and when altering.
https://www.postgresql.org/docs/11/sql-alterdatabase.html
https://www.postgresql.org/docs/9.6/sql-alterdatabase.html
https://www.postgresql.org/docs/11/sql-createdatabase.html
https://www.postgresql.org/docs/9.6/sql-createdatabase.html