Treat $version as an integer for comparison, defaults to string #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfrancrisko
suggested changes
Jan 30, 2020
There was a problem hiding this comment.
Hi @boydtom! Thanks for highlighting this issue and submitting this change request. @DavidS made me aware of the versioncmp function that might be able to achieve what you're looking to do. I've left an example in the PR, if you wouldn't mind having a look and making the change if you're happy? We should be good to merge after that.
Thanks again!
|
LGTM @boydtom - thanks again for the fix! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting password_encryption an operator AND calls a comparison of the $version variable to an integer. $version is a string - breaking the comparison. This should fix that - although it may not be the best way to do so and someone with greater skill has a better method.