Correct versioncmp logic in config.pp #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boydtom I should have caught this in the review, so there's at least equal, if not more blame on myself! Thanks for getting a fix together so quickly. |
sanfrancrisko
changed the title
sanfrancrisko
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit embarrassing but my last patch, although not breaking anything from prior state, also will not actually work as intended. Version comparison works but versioncmp produces results of -1, 0 or 1 and must be compared against that result.
This fix I tested more thoroughly. :) Sorry for the hassle.