Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-10610) Use correct lower bound for concat version #1160

Merged
merged 1 commit into from Apr 3, 2020
Merged

(MODULES-10610) Use correct lower bound for concat version #1160

merged 1 commit into from Apr 3, 2020

Conversation

ghoneycutt
Copy link
Contributor

No description provided.

@ghoneycutt ghoneycutt requested a review from a team as a code owner April 1, 2020 18:31
@sheenaajay
Copy link
Contributor

Thanks @ghoneycutt for submitting the PR.

@sheenaajay sheenaajay merged commit 84df848 into puppetlabs:master Apr 3, 2020
@ghoneycutt ghoneycutt deleted the MODULES_10610_fix_concat_version_requirements branch April 3, 2020 17:25
@alexjfisher
Copy link
Collaborator

Should this really have the backwards-incompatible label? If the old information was wrong, then IMO, fixing it isn't a breaking change.

@ghoneycutt
Copy link
Contributor Author

@sheenaajay @alexjfisher This should not have the backwards-incompatible label applied. The old information was incorrect. This PR fixes that incorrect metadata, it does not change functionality and certainly not in a way that would be backwards-incompatible.

@ghoneycutt
Copy link
Contributor Author

For perspective, the force attribute to concat in manifests/server/recovery.pp was introduced in 5.6.0, so the metadata has been broken since that release about two years ago.

@sheenaajay
Copy link
Contributor

Thanks @ghoneycutt . Updated the label.

cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
@sheenaajay
Merge pull request puppetlabs#1160 from ghoneycutt/MODULES_10610_fix_…
3293067 
…concat_version_requirements

(MODULES-10610) Use correct lower bound for concat version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghoneycutt @sheenaajay @alexjfisher