Skip to content

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 19, 2020

Current code only allows for SLES 15 SP0 while released versions currently go up to SP2.
Have extended to potential SP9 to prevent the need to update again in the future as the final SP version is as of yet unknown.

@david22swan david22swan requested a review from a team as a code owner November 19, 2020 10:38
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #1209 (4ac3537) into main (08e3a51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1209   +/-   ##
=======================================
  Coverage   65.81%   65.81%           
=======================================
  Files          14       14           
  Lines         351      351           
=======================================
  Hits          231      231           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a1fed...4ac3537. Read the comment docs.

Current code only allows for SLES 15 SP0 while released versions currently go up to SP2. Have extended to potential SP9 to prevent the need to update again in the future as the final SP version is as of yet unknown.
@carabasdaniel carabasdaniel merged commit 37062e6 into puppetlabs:main Nov 20, 2020
@david22swan david22swan deleted the IAC-1189 branch November 20, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants