MODULES-11047 - Allow managing rights for PUBLIC role

[mtancoigne]

Following the feature request, this PR allow to use "PUBLIC" as a role for grants, which will not be quoted in the final query.

[puppet-community-rangefinder]

postgresql::server::grant is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

• landcareresearch-ckan

This module is declared in 70 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

All committers have signed the CLA.

[sheenaajay]

Thank you @mtancoigne for your contribution.
Could you please let us know which postgresql version you are seeing this error when revoking / granting rights from PUBLIC role.
have you tried using the postgresql::server::grant
Example:
postgresql::server::grant { 'grant select on test_tbl': privilege => 'SELECT', object_type => 'TABLE', object_name => 'test_tbl', db => $db, role => $user, }

[mtancoigne]

I tried on Postgres 12.6. I made the changes as I thought it was not supported by the module until I see the specific test on spec/unit/defines/server/grant_spec.rb: it checks for a quoted "PUBLIC" string, which is invalid (at least with tested version).

[adrianiurca]

Hey @mtancoigne, we reproduced the problem locally and this fix is working properly.
I gonna proceed to merge this PR. Thank you for your great contribution!

kind regards,
@adrianiurca