Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python package name in RHEL/CentOS 8 #1316

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

kajinamit
Copy link
Contributor

In RHEL/CentOS8, python3 is used globally instead of python2. Because
of that python-* package is no longer available and most of python
packages are named python3-*.

@kajinamit kajinamit requested a review from a team as a code owner December 5, 2021 23:47
@puppet-community-rangefinder
Copy link

postgresql::params is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kajinamit kajinamit changed the title Install python3-psycopg2 in RHEL/CentOS 8 Fix python package name in RHEL/CentOS 8 Dec 6, 2021
@tobias-urdin
Copy link

Probably do release major >= 8 or the same issue will be present in 9

In RHEL/CentOS8, python3 is used globally instead of python2. Because
of that python-* package is no longer available and most of python
packages are named python3-*.
@kajinamit
Copy link
Contributor Author

Probably do release major >= 8 or the same issue will be present in 9

That is definitely better. I updated the change accordingly.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I started the tests.

@@ -109,7 +109,11 @@
$psql_path = pick($psql_path, "${bindir}/psql")

$perl_package_name = pick($perl_package_name, 'perl-DBD-Pg')
$python_package_name = pick($python_package_name, 'python-psycopg2')
if $facts['os']['family'] == 'RedHat' and versioncmp($facts['os']['release']['major'], '8') >= 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud: this will also cover Fedora. It will break Fedora versions which are still primarily Python 2 but those are EOL anyway. Probably not a big deal.

@ekohl
Copy link
Collaborator

ekohl commented Dec 9, 2021

Test failures look like timeouts, ignoring those.

@ekohl ekohl merged commit 1f352c1 into puppetlabs:main Dec 9, 2021
@ekohl ekohl added the bugfix label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants