(MODULES-11251) Add support for backup provider "pg_dump"

[fraenki]

This adds support for backup "providers" to puppetlabs/postgresql. The feature is heavily inspired by a similar feature in puppetlabs/mysql.

See Puppet ticket for full details:
https://tickets.puppetlabs.com/browse/MODULES-11251

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

postgresql::backup::pg_dump is a class

that may have no external impact to Forge modules.

postgresql::params is a class

that may have no external impact to Forge modules.

postgresql::server is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

Hi,
I like the idea and added some inline comments. I want to mention that Vox Pupuli also has a module to do database dumps: https://forge.puppet.com/modules/puppet/dbbackup#table-of-contents

[fraenki]

Hi, I like the idea and added some inline comments. I want to mention that Vox Pupuli also has a module to do database dumps: https://forge.puppet.com/modules/puppet/dbbackup#table-of-contents

Thanks for the review. Actually I've already had a look at puppet/dbbackup, but I really like the integrated approach of puppetlabs/mysql's backup feature, and I cannot use systemd, which lead to the creation of this PR. :)

[fraenki]

I've added some tests with the latest commit.

[github-actions]

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[puppet-community-rangefinder]

postgresql::backup::pg_dump is a class

that may have no external impact to Forge modules.

postgresql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):

• tailoredautomation-patroni
• aursu-gitlabinstall

Breaking changes to this file MAY impact these 3 modules (near match):

• puppetfinland-trac
• maestrodev-continuum
• puppetfinland-bacula

postgresql::server is a class

Breaking changes to this file WILL impact these 38 modules (exact match):

• treydock-keycloak
• theforeman-foreman
• bltavares-baseline
• nicopaez-dockerserver
• jmkeyes-razor
• jjulien-trac
• dmexe-rails
• atmesh-deploy_railsapp
• landcareresearch-pidservice
• eschiller-trac
• driebit-zotonic
• katello-gutterball
• chedi-django
• nicopaez-alfred
• nicopaez-triage
• mjhas-mailserver
• lwo-dataverse
• adullact-fusionforge
• urgi-galaxy_roles_profiles
• hetzner-roundcube
• mukaibot-bamboo
• maestrodev-maestro
• opuscodium-taiga
• sensson-powerdns
• npwalker-pe_external_postgresql
• adullact-demarchessimplifiees
• zleslie-bacula
• theforeman-pulpcore
• landcareresearch-postgis
• SchnWalter-happydev
• groupbuddies-gb
• katello-candlepin
• blackknight36-bacula
• puppetlabs-puppetdb
• conzar-pidservice
• conzar-ckan
• nnutter-testdb
• Ginja-puppet_stack

Breaking changes to this file MAY impact these 16 modules (near match):

• jmkeyes-netbox
• lboynton-gitlab
• Firebladee-moodle
• knowshan-phppgadmin
• fiddyspence-zabbix
• binford2k-drupal
• dmexe-deploy
• jortencio-superset
• 4geeks-odoo
• simp-foreman
• maestrodev-continuum
• vshn-uhosting
• Lavaburn-cabot
• ash-netbox
• icinga-icinga
• cleo-harmony

This module is declared in 70 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

dear puppet, please do not autoclose PR that are only stale because nine of you reviewed it...

@fraenki sadly this now needs a rebase, could you please do that?

[github-actions]

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

[fraenki]

PR needs a review, I'll rebase ASAP...

[chelnak]

hey @fraenki ! Appreciated!

[fraenki]

@chelnak Rebased. Ready for review :)

[chelnak]

Hey @fraenki ! I'm on PTO this week so pinging @pmcmaw and @david22swan for assistance!

[david22swan]

@fraenki Look's like your getting a few spec test failures.

[fraenki]

I've force-pushed a fix, please re-run the spec tests.

[fraenki]

Since I'm unable to run the tests locally, I need to request a re-run of the spec tests again... :-/

[fraenki]

The spec tests are finally passing. 🎉
(However, some tests seem to timeout, which is also the case for the nightly tests.)

[fraenki]

@chelnak @david22swan What do you think? Can this PR be merged? :)

[david22swan]

LGTM

Apologies for the wait on this.
Anyway it look's good to me so I'm gonna go ahead and merge :)
Thank's for putting in the work