Skip to content

Use systemctl reload on EL 7 and higher #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Mar 8, 2022

This means it'll work on EL9. It's also safe to assume future EL versions use systemd.

@ekohl ekohl requested a review from a team as a code owner March 8, 2022 15:22
@puppet-community-rangefinder
Copy link

postgresql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 3 modules (near match):

This module is declared in 70 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

smortex
smortex previously approved these changes Mar 9, 2022
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kenyon
kenyon previously approved these changes Mar 9, 2022
bastelfreak
bastelfreak previously approved these changes Mar 23, 2022
@bastelfreak
Copy link
Collaborator

@ekohl can you rebase please?

This means it'll work on EL9. It's also safe to assume future EL
versions use systemd.
@ekohl ekohl dismissed stale reviews from bastelfreak, kenyon, and smortex via a42ddb9 March 30, 2022 11:03
@github-actions
Copy link

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

@bastelfreak
Copy link
Collaborator

I still think having this bot is a very bad idea

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed looks good.

@david22swan
Copy link
Member

LGTM
Thank's for the commit and sorry it took a while to get to it.

@david22swan david22swan merged commit 833faa8 into puppetlabs:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants