Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version for Ubuntu 22.04 #1350

Merged
merged 1 commit into from Jul 4, 2022
Merged

Conversation

arjenz
Copy link
Contributor

@arjenz arjenz commented Jul 4, 2022

Ubuntu 22.04 ships with version 14.

@arjenz arjenz requested a review from a team as a code owner July 4, 2022 09:46
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 19 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl
Copy link
Collaborator

ekohl commented Jul 4, 2022

I'm not sure if CI already has support for running Ubuntu 22.04, which would be good to have. IIRC the packages do exist now. @david22swan could you answer this?

@arjenz
Copy link
Contributor Author

arjenz commented Jul 4, 2022

I don't think there's full support yet, repo service mentions jammy, but I think it was pretty empty still (I installed puppet-agent_6.27.1-1focal_amd64.deb manually to test, "it just works").

I explicitly also chose to just fill the variable (and not touch any metadata referring to 22.04), as with the variable filled it seems to "just work", which I guess is the first step towards "Is supported".

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with merging this partial support, but adding official support would be nice.

@david22swan
Copy link
Member

@ekohl @arjenz Ubuntu 22.04 support has just recently been added to the Agent nightlies, but not yet the official release, so it is in the pipeline.
There are a few other tasks that precede it but once they are done we will be moving onto it and getting support out.

In regards to this change, it LGTM so I'm happy to get some compatibility in prior to the official support getting added.
Will put it in as a bugfix though to indicate it's not an outright addition.

@david22swan david22swan merged commit 8eca982 into puppetlabs:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants