(maint) Codebase Hardening #1366

david22swan · 2022-09-13T08:28:46Z

Changes made to ensure that no malformed commands are passed through to the system.
Certain commands were left undivided as the commands did not get correctly interpreted.

puppet-community-rangefinder · 2022-09-13T08:29:16Z

postgresql::server::config is a class

that may have no external impact to Forge modules.

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

tedivm-hieratic

postgresql::server::passwd is a class

that may have no external impact to Forge modules.

postgresql::validate_db_connection is a type

Breaking changes to this file WILL impact these 3 modules (exact match):

Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 579 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

puppet-community-rangefinder · 2022-09-13T09:16:11Z

postgresql::server::config is a class

that may have no external impact to Forge modules.

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

tedivm-hieratic

postgresql::server::passwd is a class

that may have no external impact to Forge modules.

postgresql::validate_db_connection is a type

Breaking changes to this file WILL impact these 3 modules (exact match):

Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 579 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

puppet-community-rangefinder · 2022-09-13T10:03:57Z

postgresql::server::config is a class

that may have no external impact to Forge modules.

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):

Breaking changes to this file MAY impact these 1 modules (near match):

tedivm-hieratic

postgresql::server::passwd is a class

that may have no external impact to Forge modules.

postgresql::validate_db_connection is a type

Breaking changes to this file WILL impact these 3 modules (exact match):

Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 579 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl

It surprises me that you need to escape values when passing as an array. In most programming languages the array is passed straight to the invocation, without any shell involved. Doesn't Puppet do this natively? If not, why are command arrays even implemented in the first place?

manifests/server/config.pp

manifests/server/config_entry.pp

manifests/validate_db_connection.pp

manifests/server/config.pp

manifests/validate_db_connection.pp

david22swan · 2022-09-13T15:51:23Z

Not sure where these 6 failures are coming from?

manifests/server/config_entry.pp

spec/defines/validate_db_connection_spec.rb

manifests/server/passwd.pp

spec/classes/server/config_spec.rb

spec/classes/server_spec.rb

Changes made to ensure that no malformed commands are passed through to the system. Certain commands were left undivided as the commands did not get correctly interpreted and so a shell_escape was used instead.

david22swan · 2022-10-07T17:08:20Z

Spec test failures replicated on main branch

manifests/server/config_entry.pp

david22swan added the bugfix label Sep 13, 2022

david22swan requested a review from a team as a code owner September 13, 2022 08:28

david22swan force-pushed the maint/codebase_hardening branch 2 times, most recently from 645d67f to 84c3974 Compare September 13, 2022 09:05

david22swan closed this Sep 13, 2022

david22swan reopened this Sep 13, 2022

david22swan force-pushed the maint/codebase_hardening branch from 84c3974 to 9a9dbee Compare September 13, 2022 09:15

david22swan force-pushed the maint/codebase_hardening branch from 9a9dbee to fbe87d1 Compare September 13, 2022 09:43

david22swan closed this Sep 13, 2022

david22swan reopened this Sep 13, 2022

david22swan force-pushed the maint/codebase_hardening branch 2 times, most recently from 780e311 to f2835a8 Compare September 13, 2022 10:13

ekohl reviewed Sep 13, 2022

View reviewed changes

manifests/server/config.pp Outdated Show resolved Hide resolved

manifests/server/config_entry.pp Outdated Show resolved Hide resolved

manifests/server/config_entry.pp Outdated Show resolved Hide resolved

david22swan force-pushed the maint/codebase_hardening branch 3 times, most recently from cb79720 to f2725cb Compare September 13, 2022 11:12

ekohl reviewed Sep 13, 2022

View reviewed changes

manifests/validate_db_connection.pp Outdated Show resolved Hide resolved

david22swan force-pushed the maint/codebase_hardening branch 2 times, most recently from 99fc479 to a315ede Compare September 13, 2022 13:34

ekohl reviewed Sep 13, 2022

View reviewed changes

manifests/server/config.pp Outdated Show resolved Hide resolved

manifests/validate_db_connection.pp Outdated Show resolved Hide resolved

david22swan force-pushed the maint/codebase_hardening branch from a315ede to 2fe8863 Compare September 13, 2022 15:26

david22swan force-pushed the maint/codebase_hardening branch from 2fe8863 to 922cd64 Compare September 14, 2022 08:53

ekohl reviewed Sep 14, 2022

View reviewed changes

manifests/server/config_entry.pp Outdated Show resolved Hide resolved

spec/defines/validate_db_connection_spec.rb Outdated Show resolved Hide resolved

david22swan force-pushed the maint/codebase_hardening branch 2 times, most recently from cf1f282 to 800c292 Compare September 14, 2022 15:03

ekohl requested changes Sep 22, 2022

View reviewed changes

manifests/server/passwd.pp Show resolved Hide resolved

spec/classes/server/config_spec.rb Outdated Show resolved Hide resolved

spec/classes/server_spec.rb Outdated Show resolved Hide resolved

david22swan force-pushed the maint/codebase_hardening branch from 800c292 to 7767658 Compare October 7, 2022 16:13

(maint) Codebase Hardening

ab7a695

Changes made to ensure that no malformed commands are passed through to the system. Certain commands were left undivided as the commands did not get correctly interpreted and so a shell_escape was used instead.

david22swan force-pushed the maint/codebase_hardening branch from 7767658 to ab7a695 Compare October 7, 2022 16:28

LukasAud approved these changes Oct 11, 2022

View reviewed changes

manifests/server/config_entry.pp Show resolved Hide resolved

LukasAud merged commit 6bad26d into puppetlabs:main Oct 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(maint) Codebase Hardening #1366

(maint) Codebase Hardening #1366

Uh oh!

david22swan commented Sep 13, 2022 •

edited

Loading

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

Uh oh!

ekohl left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david22swan commented Sep 13, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david22swan commented Oct 7, 2022

Uh oh!

Uh oh!

Uh oh!

(maint) Codebase Hardening #1366

(maint) Codebase Hardening #1366

Uh oh!

Conversation

david22swan commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

postgresql::server::config is a class

postgresql::server::config_entry is a type

postgresql::server::passwd is a class

postgresql::validate_db_connection is a type

This module is declared in 70 of 579 indexed public Puppetfiles.

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

postgresql::server::config is a class

postgresql::server::config_entry is a type

postgresql::server::passwd is a class

postgresql::validate_db_connection is a type

This module is declared in 70 of 579 indexed public Puppetfiles.

Uh oh!

puppet-community-rangefinder bot commented Sep 13, 2022

postgresql::server::config is a class

postgresql::server::config_entry is a type

postgresql::server::passwd is a class

postgresql::validate_db_connection is a type

This module is declared in 70 of 579 indexed public Puppetfiles.

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david22swan commented Sep 13, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david22swan commented Oct 7, 2022

Uh oh!

Uh oh!

Uh oh!

david22swan commented Sep 13, 2022 •

edited

Loading

This module is declared in 70 of 579 indexed public `Puppetfiles`.

This module is declared in 70 of 579 indexed public `Puppetfiles`.

This module is declared in 70 of 579 indexed public `Puppetfiles`.