Skip to content

pg_hba_rule: Move type datatype to own type #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

bastelfreak
Copy link
Collaborator

This makes it easier to test the type, and people can use it in their downstream modules. In addition I added the type hostnogssenc. The list is now complete/covers all auth types from PostgreSQL 14.

@bastelfreak bastelfreak requested a review from a team as a code owner October 11, 2022 13:04
@puppet-community-rangefinder
Copy link

postgresql::server::pg_hba_rule is a type

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 70 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak
Copy link
Collaborator Author

I rebased the branch against #1372 because main has some issues that Martin fixed in #1372.

@bastelfreak bastelfreak force-pushed the enum branch 3 times, most recently from b9e60f0 to c2be64e Compare October 11, 2022 14:27
@david22swan
Copy link
Member

david22swan commented Oct 11, 2022

@bastelfreak Have squash merged in the other PR.
If you could rebase your work I would be happy to merge this as well

This makes it easier to test the type, and people can use it in their
downstream modules. In addition I added the type `hostnogssenc`. The
list is now complete/covers all auth types from PostgreSQL 14.
@bastelfreak
Copy link
Collaborator Author

@david22swan rebased it :)

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 38fa73b into puppetlabs:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants