(CONT-792) - Add Puppet 8/Drop Puppet 6

[jordanbreen28]

This PR adds support for Puppet 8 and Drops support for puppet 6.

[puppet-community-rangefinder]

postgresql::postgresql_password is a function

Breaking changes to this file WILL impact these 11 modules (exact match):

• adullact-tajine
• adullact-cfssl
• adullact-demarchessimplifiees
• theforeman-pulpcore
• puppet-zabbix
• treydock-keycloak
• katello-candlepin
• openstack-openstacklib
• theforeman-foreman
• sensu-sensu
• puppetlabs-puppetdb

Breaking changes to this file MAY impact these 3 modules (near match):

• jortencio-superset
• puppetfinland-patchwork
• icinga-icinga

postgresql_psql is a type

Breaking changes to this file WILL impact these 8 modules (exact match):

• puppetlabs-puppetdb
• npwalker-pe_databases
• sensson-powerdns
• camptocamp-postgis
• landcareresearch-ckan
• conzar-ckan
• mjhas-mailserver
• driebit-zotonic

Breaking changes to this file MAY impact these 7 modules (near match):

• puppetlabs-postgresql
• tedivm-hieratic
• godp1301-postgresql
• jlcox-postgresplus
• eyp-postgresql
• simp-postgresql
• memoussati-postgresql

postgresql_replication_slot is a type

Breaking changes to this file MAY impact these 1 modules (near match):

• tedivm-hieratic

This module is declared in 70 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[LukasAud]

LGTM

[alexjfisher]

Puppetserver 7 is only jruby 9.3 and therefore only compatible with ruby 2.6. If you try to fix any of the rubocop_todo.yml contents you will likely break this module for all users (since Puppet 8 isn't even out yet)

EDIT: Lots of cops were corrected, but I can't tell if any of them here do enforce 2.7+ features though. Big risk IMO though.

[jordanbreen28]

@alexjfisher thanks for being thorough and bringing this to our attention.. You have prompted an important conversation in the team.