port: Enforce Stdlib::Port datatype #1473
Merged
+27
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
SimonHoenscheid
previously approved these changes
Aug 28, 2023
bastelfreak
force-pushed
the
port
branch
3 times, most recently
from
ed934fe
to
d722f9a
Compare
|
I don't mind this, but can we wait until there are more backwards incompatible changes lined up? Perhaps even implement a deprecation where it changes the tests to integers and generates a warning in the stable release that string ports will be removed in the next release? |
|
I will see if we can do a minor release before merging #1450 , then we could release a warning |
|
@bastelfreak a minor release would be nice. There are some changes lined up and getting those out is good. |
5 tasks
|
This should be merged after the 9.2.0 release |
|
This is now ready for review and merge |
bastelfreak
added
community
backwards-incompatible
and removed
community
backwards-incompatible
labels
SimonHoenscheid
previously approved these changes
Aug 30, 2023
smortex
previously approved these changes
Aug 30, 2023
bastelfreak
dismissed stale reviews from smortex and SimonHoenscheid
via
c572647
jcpunk
approved these changes
Aug 30, 2023
ekohl
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)