Drop postgresql 8.1/RHEL5 specific code #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
alexjfisher,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
ekohl
reviewed
Aug 30, 2023
There was a problem hiding this comment.
If you do this, I'd also drop setting the default to 8.1 for some OSes and also remove test code.
And dropping 8.1 is probably fine, but I think Puppetlabs will want to continue supporting RHEL 6 while that's supported by Red Hat and that means keeping 8.4 I think.
|
I dropped all postgresql 8.1 or RHEL 5 specific code. The metadata.json only mentions RHEL7 and newer so I think that's fine. |
bastelfreak
changed the title
bastelfreak
force-pushed
the
81
branch
3 times, most recently
from
84dece8
to
4a6a13b
Compare
Ramesh7
approved these changes
Aug 31, 2023
In the past Puppet has had this weird policy where they didn't list something in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)