Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Debian 12 as supported system #1488

Merged
merged 1 commit into from Apr 10, 2024
Merged

List Debian 12 as supported system #1488

merged 1 commit into from Apr 10, 2024

Conversation

deric
Copy link
Collaborator

@deric deric commented Aug 31, 2023

Summary

Debian 12 has been removed from supported systems (f10ee71). Now since puppetlabs/litmusimage#62 has been merged, there should be a docker image available.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Aug 31, 2023

Hi @deric Thanks for raising the PR. I have checked yesterday after taking on puppetlabs/litmusimage#62 and got to know that the Agent is not yet compatible with Debian12, so don't think so make sense to proceed with this change unless we get official support for the Debian 12.
But will keep eye on this one and take it forward once we get official support of Debian 12.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Aug 31, 2023

Also if you look at https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/6034903052/job/16374201436?pr=1488 (GitHub CI run) its still skipping Debian12.

Warning: Cannot find image for Debian-12
Screenshot 2023-08-31 at 2 16 24 PM

@deric
Copy link
Collaborator Author

deric commented Aug 31, 2023

@Ramesh7 Thanks for looking into this. The job definition is here: https://github.com/puppetlabs/cat-github-actions/blob/main/.github/workflows/module_ci.yml#L47C35-L47C35, right? But where is the method matrix_from_metadata_v2 defined?

@cruelsmith
Copy link
Contributor

The matrix_from_metadata_v2 is part of the puppet_litmus gem. With https://github.com/puppetlabs/puppet_litmus/pull/523/files Debian-12 has been added so this one should now work? Needs a rerun of the workflow to verify.

@cruelsmith
Copy link
Contributor

cruelsmith commented Sep 7, 2023

Oh the version bump for the puppet_lintmus gem that adds it is still open puppetlabs/puppet_litmus#524

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 12, 2023

Oh the version bump for the puppet_lintmus gem that adds it is still open puppetlabs/puppet_litmus#524

@cruelsmith @deric wanted to update here that the Debian 12 OS is not yet officially supported by Puppet, so will not recommend to use with Debian12 OS. The PR in litmus to add Debian12 got raised for experimental purpose only.

@bastelfreak
Copy link
Collaborator

I rebased this against main

@bastelfreak
Copy link
Collaborator

This PR also contains #1592

bastelfreak
bastelfreak previously approved these changes Apr 10, 2024
@bastelfreak bastelfreak dismissed their stale review April 10, 2024 15:36

The merge-base changed after approval.

bastelfreak
bastelfreak previously approved these changes Apr 10, 2024
@deric deric dismissed bastelfreak’s stale review April 10, 2024 15:36

The merge-base changed after approval.

@bastelfreak bastelfreak merged commit 7e2d817 into main Apr 10, 2024
3 checks passed
@bastelfreak bastelfreak deleted the debian12 branch April 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants