server::grant: make port optional/restore connect_settings feature #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
alexjfisher,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
ekohl
reviewed
Aug 31, 2023
bastelfreak
force-pushed
the
server_grant
branch
4 times, most recently
from
95b8e3a
to
967850d
Compare
Previously the port parameter had a default value. This broke the logic to identify the port. The port is now optional. If it's not set, $connect_settings is checked for PGPORT. If that also doesn't exist, the default from the server class is used.
bastelfreak
force-pushed
the
server_grant
branch
from
967850d
to
4304290
Compare
ekohl
approved these changes
Aug 31, 2023
SimonHoenscheid
approved these changes
Aug 31, 2023
bastelfreak
changed the title
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the port parameter had a default value. This broke the logic
to identify the port. The port is now optional. If it's not set,
$connect_settings is checked for PGPORT. If that also doesn't exist, the
default from the server class is used.