postgresql_conf: Fix regex for value param and add tests #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHoenscheid
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
smortex and
a team
as code owners
bastelfreak
changed the title
deric
previously approved these changes
Oct 25, 2023
|
I raised #1545 just with the tests so we can compare it. |
|
Can we first merge #1546 please, which adds the passing tests. |
|
waiting for #1546 to pass the CI |
SimonHoenscheid
dismissed
deric’s stale review
The merge-base changed after approval.
SimonHoenscheid
force-pushed
the
fix_regex_add_tests
branch
from
3ddc7bb to
e3dabd1
Compare
bastelfreak
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1536