Skip to content

Conversation

mcanevet
Copy link
Contributor

This should fail because it will try to add CREATE privilege to a table because of this: https://github.com/camptocamp/puppet-postgresql/blob/master/manifests/server/grant.pp#L60

The fix will come in another commit

@kbarber-jenkins2
Copy link

Can one of the admins verify this patch?

@mcanevet
Copy link
Contributor Author

test this please

@mcanevet
Copy link
Contributor Author

@kbarber could you please launch rspec-system on this PR (I thought we were in your whitelist :-) )?

@kbarber
Copy link
Contributor

kbarber commented Nov 14, 2013

@kbarber-jenkins2 ok to test

@kbarber-jenkins2
Copy link

Merged build finished.

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-postgresql/405/

@mcanevet
Copy link
Contributor Author

OK, that's the result I wanted:

Error evaluating 'unless' clause: 'ERROR: unrecognized privilege type: "CREATE"

Now I can commit the fix

@kbarber-jenkins2
Copy link

Merged build triggered.

@kbarber-jenkins2
Copy link

Merged build started.

@kbarber-jenkins2
Copy link

Merged build finished.

@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-postgresql/409/

@mcanevet
Copy link
Contributor Author

@kbarber @apenney could you please merge this one ?

'ALL' => 'INSERT',
default => $_privilege,
}
validate_string($unless_privilege,'SELECT','INSERT','UPDATE','REFERENCES',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed we are missing TRUNCATE and TRIGGER. I don't suppose you can add them now?

Ref: http://www.postgresql.org/docs/9.3/static/sql-grant.html

@kbarber-jenkins2
Copy link

Merged build triggered.

@kbarber-jenkins2
Copy link

Merged build started.

@kbarber-jenkins2
Copy link

Merged build finished.

@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-postgresql/411/

kbarber added a commit that referenced this pull request Nov 15, 2013
Fix table_grant_spec to show a bug
@kbarber kbarber merged commit c114885 into puppetlabs:master Nov 15, 2013
@mcanevet mcanevet deleted the table_grant_fix branch November 16, 2013 07:58
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Oct 23, 2017
@Ramesh7 Ramesh7 added the bugfix label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants