-
Notifications
You must be signed in to change notification settings - Fork 612
Fix table_grant_spec to show a bug #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
test this please |
@kbarber could you please launch rspec-system on this PR (I thought we were in your whitelist :-) )? |
@kbarber-jenkins2 ok to test |
Merged build finished. |
Test FAILed. |
OK, that's the result I wanted: Error evaluating 'unless' clause: 'ERROR: unrecognized privilege type: "CREATE" Now I can commit the fix |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test PASSed. |
'ALL' => 'INSERT', | ||
default => $_privilege, | ||
} | ||
validate_string($unless_privilege,'SELECT','INSERT','UPDATE','REFERENCES', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed we are missing TRUNCATE and TRIGGER. I don't suppose you can add them now?
Ref: http://www.postgresql.org/docs/9.3/static/sql-grant.html
Merged build triggered. |
Merged build started. |
Merged build finished. |
Test PASSed. |
Fix table_grant_spec to show a bug
Fix table_grant_spec to show a bug
This should fail because it will try to add CREATE privilege to a table because of this: https://github.com/camptocamp/puppet-postgresql/blob/master/manifests/server/grant.pp#L60
The fix will come in another commit