fix for concat error

[flypenguin]

This fixes a - in my opinion - critical bug which leads to a puppet run abort.

using a fairly new concat and postgresql module, this happens:

• postgresql is the first module which uses concat which gets realized by puppet
• concat was not yet initialized, so it does its initialization (create /var/lib/puppet/concat ...)
• puppet aborts with a user postgres not found error

What happens is that on first run, without being initialized, the concat module wants to create its helper directories. But postgresql defines a standard user for all File{} objects, which does not yet exist (the package is not yet installed), and would be horribly wrong anyway.

I did not find any practical use of the general File{} definition, so I removed it, and so far it works.

[domcleal]

I just hit this too and came to the same conclusion.. I can't see any use of the File { } defaults. It's deprecated in concat 1.1.0 to specify owner/mode etc on the fragments anyway.

[domcleal]

For the record, without this you can get the following error with puppetlabs-concat 1.1.0:

err: /Stage[main]/Concat::Setup/File[/var/lib/puppet/concat]/ensure: change from absent to directory failed: Could not set 'directory on ensure: Could not find user postgres at /etc/puppet/modules/concat/manifests/setup.pp:49