Fix comment detection #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On psql 8.1, `pg_catalog.shobj_description` does not exist. Also, if the database to comment is not the current db then this warning will be raised and the comment will not be applied: `WARNING: database comments may only be applied to the current database` This fix uses the pg_* databases to find the comment based on the database oid rather than the shared object description function.
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
Fix comment detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On psql 8.1,
pg_catalog.shobj_descriptiondoes not exist. Also, if thedatabase to comment is not the current db then this warning will be
raised and the comment will not be applied:
WARNING: database comments may only be applied to the current databaseThis fix uses the pg_* databases to find the comment based on the
database oid rather than the shared object description function.