(MODULES-1127) allow LANGUAGE as valid object_type #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A community request came in from someone wanting to be able to grant usage on language and it was being blocked by `validate_re` in ::server::grant. This commit adds LANGUAGE to the allowed list of object types.
Adding LANGUAGE to the initial validation list was not enough, some additional params needed to be defined. Acceptance tests were also added to verify USAGE could be granted on the plpgsql language, which ships with postgres
This adds an additional test for the onlyif_exists function which should skip the command if the language specified does not exist. This is a hardcoded psql command that could need to be updated in the future and should be tested for.
eputnam
added a commit
to eputnam/puppetlabs-postgresql
that referenced
this pull request
Feb 9, 2017
Tests from puppetlabs#838 broke because the CREATE AND REPLACE LANGUAGE command is not available until postgresql 9. I originally thought that using only CREATE LANGUAGE would not be idempotent, but it turns out it is. This commit changes CREATE AND REPLACE LANGUAGE to CREATE LANGUAGE.
eputnam
added a commit
to eputnam/puppetlabs-postgresql
that referenced
this pull request
Feb 9, 2017
Tests from puppetlabs#838 broke because the CREATE AND REPLACE LANGUAGE command is not available until postgresql 9. I originally thought that using only CREATE LANGUAGE would not be idempotent, but it turns out it is. This commit changes CREATE AND REPLACE LANGUAGE to CREATE LANGUAGE.
eputnam
added a commit
to eputnam/puppetlabs-postgresql
that referenced
this pull request
Feb 10, 2017
Tests from puppetlabs#838 broke because the CREATE AND REPLACE LANGUAGE command is not available until postgresql 9. I originally thought that using only CREATE LANGUAGE would not be idempotent, but it turns out it is. This commit changes CREATE AND REPLACE LANGUAGE to CREATE LANGUAGE.
diogokiss
pushed a commit
to Tradeshift/puppetlabs-postgresql
that referenced
this pull request
Jan 3, 2019
Tests from puppetlabs#838 broke because the CREATE AND REPLACE LANGUAGE command is not available until postgresql 9. I originally thought that using only CREATE LANGUAGE would not be idempotent, but it turns out it is. This commit changes CREATE AND REPLACE LANGUAGE to CREATE LANGUAGE.
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Tests from puppetlabs#838 broke because the CREATE AND REPLACE LANGUAGE command is not available until postgresql 9. I originally thought that using only CREATE LANGUAGE would not be idempotent, but it turns out it is. This commit changes CREATE AND REPLACE LANGUAGE to CREATE LANGUAGE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A community request came in from someone wanting to be able to grant usage on language and it was being blocked by
validate_rein ::server::grant. This commit adds LANGUAGE to the allowed list of object types.Adding LANGUAGE to the initial validation list was not enough, some additional params needed to be defined. Acceptance tests were also added to verify USAGE could be granted on the plpgsql language, which ships with postgres