Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowo to disable managing passwords for users #846

Merged
merged 2 commits into from May 9, 2017
Merged

Allowo to disable managing passwords for users #846

merged 2 commits into from May 9, 2017

Conversation

bjoernhaeuser
Copy link
Contributor

No description provided.

@bjoernhaeuser
Copy link
Contributor Author

The problem is that pg_shadow and pg_authid is not accessible inside RDS postgres instance. Nonetheless creating roles with a passwords works, but a second run would fail because it cannot verify that it has to change the password.

The other option would be to always alter the password, but this sounds even more sketchy to me.

@bjoernhaeuser
Copy link
Contributor Author

Rebased to current master.

README.md Outdated
@@ -1445,6 +1445,9 @@ Default value: `true`.
##### `password_hash`
Sets the hash to use during password creation. If the password is not already pre-encrypted in a format that PostgreSQL supports, use the `postgresql_password` function to provide an MD5 hash here, for example:

##### `refresh_password`
If set to true, refreshes the password on changes. Set this to false if your user is not allowed to view current passwords of user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of update_password would make more sense, as setting this to false would stop puppet from trying to update the password even when it IS able to retrieve the password hashes from the database.

Also, reflecting that this stops puppet from changing the password even if it can retrieve them, could you update the docs to reflect a use case of something like "Set this to false to not modify the role's password after creation."

@bjoernhaeuser
Copy link
Contributor Author

@hunner changed! Thank you for reviewing.

@hunner hunner merged commit 39a5790 into puppetlabs:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants