Fix creation of recovery.conf file when recovery configuration is not specified #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration is not specified
cdloh
force-pushed
the
fix-recovery-conf
branch
3 times, most recently
from
6ceb484
to
1f92473
Compare
david22swan
approved these changes
Jun 14, 2018
david22swan
requested changes
Jun 19, 2018
|
Passed on Adhoc |
|
@david22swan in my opinion the doco already suggests this behavior. Is there somewhere else that I need to update? See below snippet from the repo readme
|
|
I've added further clarification within the readme in the Defined Types area of the documentation |
david22swan
approved these changes
Jun 19, 2018
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Fix creation of recovery.conf file when recovery configuration is not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://tickets.puppetlabs.com/browse/MODULES-4276
See also #603 (comment)
Rebase of orginial MR #834