Start managing CI files #269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 2 2
Lines 183 183
=====================================
Misses 183 183Continue to review full report at Codecov.
|
| --- | ||
| os: | ||
| - linux | ||
| # OSX Only tests on the latest Puppet Gem, not the full matrix as there's no need to double up |
There was a problem hiding this comment.
CAn probably move this comment into .sync.yml
DavidS
force-pushed
the
start_managing_ci
branch
from
bf7ae02 to
976d1ae
Compare
glennsarti
left a comment
glennsarti
left a comment
There was a problem hiding this comment.
🚢 it!!!
Thanks @DavidS
glennsarti
left a comment
glennsarti
left a comment
There was a problem hiding this comment.
And... I need to change my review
The Travis CI Test stage doesn't actually test anything. And rspec isn't running on MacOSX
|
@glennsarti I don't see how this PR would disable the testing - I'll have a more in-depth look later, but would appreciate any insight you have |
|
@DavidS It looks like the stages bit is "breaking" it. There's no |
|
@glennsarti that seems to be a problem unrelated to this PR. Looking at a previous run from https://travis-ci.org/puppetlabs/puppetlabs-powershell/builds/620050367 the exactly same behaviour is there. Might need a separate ticket then. |
DavidS
force-pushed
the
start_managing_ci
branch
from
976d1ae to
0d3a1aa
Compare
|
Due to travis' propensity to multiply cells within a stage, I've now removed the main We can revisit this when moving over to litmus. |
|
@glennsarti are you happy with this solution? |
This requires a few changes to the pdk-templates from this PR: puppetlabs/pdk-templates#293