Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10389) - Safeguard powershell provider loading #277

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

michaeltlombardi
Copy link
Contributor

This modifies the providers to use a confine statement to a feature found in the dependent pwshlib module, preventing Puppet runs from failing outright if the dependency is not found.

@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #277   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           2      2           
  Lines         183    183           
=====================================
  Misses        183    183
Impacted Files Coverage Δ
lib/puppet/provider/exec/pwsh.rb 0% <0%> (ø) ⬆️
lib/puppet/provider/exec/powershell.rb 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d33fb9...31fec64. Read the comment docs.

@david22swan
Copy link
Member

Updated code so that ruby-pwsh gem is no longer pointing at master

@sheenaajay sheenaajay merged commit 2bad8d5 into puppetlabs:master Jan 14, 2020
@sheenaajay sheenaajay added bugfix and removed bug labels Jan 14, 2020
@david22swan david22swan deleted the MODULES-10389 branch November 10, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants