(MODULES-10539) Remove commands idiom from PowerShell provider #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in draft format until the litmus acceptance test rewrites are completed and merged so the changes can be verified in acceptance and additional tests provided if necessary. |
Closed
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 2 2
Lines 183 174 -9
=====================================
+ Misses 183 174 -9
Continue to review full report at Codecov.
|
Prior to this commit the PowerShell exec provider used the commands idiom to load the PowerShell executable path for use. Once the module was refactored to rely on the ruby-pwsh gem via the puppetlabs/pwshlib module, the code for determining the path was updated to depend on a helper function. However, the commands method is (apparently?) evaluated during catalogue compilation, causing the Puppet run to explode unexpectedly if the dependent module is not available. This commit removes the commands idiom and relies on the feature confine which should evaluate during a Puppet run and, when that feature is not found (because puppetlabs/pwshlib is not installed) it will report that the provider is not functional rather than blow up the entire Puppet run.
carabasdaniel
approved these changes
Feb 26, 2020
sanfrancrisko
approved these changes
Feb 26, 2020
michaeltlombardi
deleted the
ticket/master/MODULES-10539-remove-command-functionality
branch
ghomem
added a commit
to ghomem/puppetlabs-docker-compat
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the PowerShell exec provider used the commands idiom to
load the PowerShell executable path for use. Once the module was refactored
to rely on the ruby-pwsh gem via the puppetlabs/pwshlib module, the code for
determining the path was updated to depend on a helper function. However,
the commands method is (apparently?) evaluated during catalogue compilation,
causing the Puppet run to explode unexpectedly if the dependent module is
not available.
This commit removes the commands idiom and relies on the feature confine which
should evaluate during a Puppet run and, when that feature is not found
(because puppetlabs/pwshlib is not installed) it will report that the provider
is not functional rather than blow up the entire Puppet run.