(MODULES-10722) Inherit pipe_timeout from timeout #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Dec 1, 2020
Prior to this commit there was no way to modify the pipe_timeout parameter when instantiating a PowerShell Manager instance, users were stuck with the default defined in ruby-pwsh (30s). If this time is insufficient to start the host process, the exec failed with no way to extend it short of modifying the provider. This commit updates the definition of the ps_manager by checking to see if the timeout parameter is specified on the resource and, if so, inheriting that to re-use for the pipe timeout.
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 174 174
=====================================
Misses 174 174
Continue to review full report at Codecov.
|
glennsarti
reviewed
Dec 2, 2020
sanfrancrisko
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit there was no way to modify the pipe_timeout
parameter when instantiating a PowerShell Manager instance, users
were stuck with the default defined in ruby-pwsh (30s). If this
time is insufficient to start the host process, the exec failed
with no way to extend it short of modifying the provider.
This commit updates the definition of the ps_manager by checking
to see if the timeout parameter is specified on the resource and,
if so, inheriting that to re-use for the pipe timeout.