Previously some runs would communicate with the default `puppet`
address. Set configuration so that all communication uses the test
server.

Disable proxy for yum repo as it will not pass through to Puppet Server and will not hand over the certs.

During investigation into network stack restarts on Windows (https://tickets.puppetlabs.com/browse/PA-663),
it was found that a file lock on puppetres.dll was causing MSI to trigger an
unforseen service restart. This commit adds an installation option to the
puppet_agent module called `msi_move_locked_files` which premptively moves files
that can cause locks, prior to the upgrade, so that the upgrade can complete
without a service restart.

This commit adds Gemfile.lock and Gemfile.local to gitignore as they should not
be tracked for this repository.

…ve-puppetres

(MODULES-4207) Optionally move puppetres.dll on Windows upgrade

(FM-5839) Ensure server is set for all actions

…ent (#199)

Fix mco/aio facts to work with strict_variables

Module params depended on `::common_appdata` being defined, which exists
in PE but not necessarily other environments. Add a new custom fact - so
names don't conflict - to cover this case.

(MODULES-4241) Add custom fact puppet_agent_appdata

Ensure the Puppet service is enabled and started on Windows after an
upgrade when it's included in the `service` param by setting
`PUPPET_AGENT_STARTUP_MODE=Automatic`.

Fixes #197.

Update test setup to work with Windows paths and install behavior.

(MODULES-4241) Enable Windows acceptance testing

PE modules also manage server.cfg, so only manage it if not already done
so by other modules. Fixes #193.

Prevent failures when STRICT_VARIABLES='yes'.

(maint) Only update server.cfg if not already managed

In reality I have not been able to contribute to this project and am fully
consumed maintaining Puppet. Remove me from the list of maintainers to reflect
reality.

Signed-off-by: Moses Mendoza <moses@puppet.com>

…s_maintainer

(maint) remove Moses as a maintainer

Previously this module was not being managed by module sync, the preferred tool
by the Modules Team at Puppet.  This commit adds a sync.yml file which will
allow this module to be managed by module sync.  The sync.yml file emulates the
existing module configuration as much as possible.

This commit updates the module for module sync configuration at commit
211ecee603.

Previously the rake task that was used by Travis was stored in the RakeFile,
however that has been removed as part of Module Sync.  This commit modifies the
Travis configuration to use the individual tasks of validate, lint then spec
instead.

Previously there was module specific configuration in the `spec_helper.rb` file
however module sync overwrites this.  This commit moves that configuration out
to the `spec_helper_local.rb` file as per module sync recommendations.

Previously, many test were failing due the existing code failing the strict
variable evaulation.  This commit:
- Uses getvar where appropriate to guard against accesing variables that are not
  defined
- Adds an `else` clause for `if` statements where they only conditionally assign
  a variable
- Uses getvar to assign a local variable, if that local variable is used in
  string interpolation later.

Previously, many tests were failing due to strict variable evaluation as not
all of the required facts were available, unlike in a real puppet run.  This
commit adds all of the required facts to the `default_facts` for spec tests
and uses defaults of nil or false.

Due to ruby 1.8.7 being so old, it is now not possible to run bundle install on
puppet agent any more.  Disabling these Travis tests until either support for
this old ruby is dropped or the bundling issue is resolved.

Previously, Travis CI runs were throwing warnings and failing to bundle in a
timely fashion because it was using the ruby gems API and was requesting too
much information.  This commit instructions bundler will download the full index
and compute the dependencies locally.  This commit also adds a `before_script`
step to output the Gemfile.lock file for debug purposes.

Previously the FUTURE_PARSER environment variable was set in the spec_helper
however that is now locked down.  This commit adds the environment variable to
the Travis CI instead.

Previously the Gemfile generated from module sync was heavily customised to
mimic the old Gemfile prior to module sync.  However this was missing critical
gems for the full acceptance test suite pipelines.  This commit removes all of
the customisations and uses the default Gemfile from module sync at commit 211ecee603.

…lesync

{WIP}(maint)(MODULES-3710) Apply module sync configs to puppet_agent module and fix strict variable tests

Previously a bug in the logic including the puppet_agent::service class
prevented it from being applied on non-PE installs using Puppet 4. Fix
it so that services are now managed for non-PE installs under Puppet 4.

The work for enabling Windows acceptance apparently missed a run of
Puppet after the uninstall. It's not clear how this was missed, but the
new logic here makes sense.

[skip ci]

(MODULES-4241) Fix Windows acceptance

Previously it was not possible to pass additional installation parameters during
an upgrade process.  In the case of MSI files this could be sensitive passwords
or other public MSI properties.  In the case of package resources, additional
options could not be added to the package resource.

This commit adds a parameter called `install_options` which mirrors the
`install_options` parameter from the package resource and then passes this down
so that it is invoked on installation (either by a package resource or in the
batch file to install the MSI)

…d-install-params

(MODULES-4214) Add additional installation parameters during upgrade

(MODULES-3994) Manage services on Puppet 4

(packaging) Prepare for 1.3.2 release